Re: gtkmm4: Box::pack_start()/pack_end()

[Murray Cumming <murrayc murrayc com>]

On Fri, 2017-04-28 at 08:31 +0200, Kjell Ahlstedt wrote:
> On 2017-04-27 12:31, Murray Cumming wrote:
> > Thoughts? Should we remove these gtkmm-specific
> > Box::pack_start()/pack_end() methods anyway? That will still have
> > the
> > same change-of-behaviour problem for this code:
> > box.pack_start(child)
> > but if an application also has code like this it will at least
> > cause a
> > compiler error that forces the developer to think about it:
> > box.pack_start(child, Gtk::PACK_SHRINK).
>  Why does Gtk::PackOptions affect only horizontal expansion and
> alignment? Look for instance at one of the 3  TreeView demo programs.
> The ScrolledWindow is expanded horizontally but not vertically.
> Before the expand and fill parameters were removed from
> gtk_box_pack_start() the ScrolledWindow was expanded in both
> directions.

Maybe our pack_start/end() implementation should set hexpand/halign or
vexpand/valign depending on the orientation, or always set both.

-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com