Re: clang-format syntax

  BreakConstructorInitializersBeforeComma: false
  ConstructorInitializerAllOnOneLineOrOnePerLine: true
  ConstructorInitializerIndentWidth: 0

Thanks. I've made that change in git.

This is not ideal:

   //                              left  top  width  height
-  m_Grid.attach(m_ScrolledWindow, 0,    2,   1,     1);
+  m_Grid.attach(m_ScrolledWindow, 0, 2, 1, 1);

It can be avoided with extra comments:

+    // clang-format off
     //                       left  top  width  height
     m_Grid.attach(m_Toolbar, 0,    1,   1,     1);
+    // clang-format on

Yes, let's do that in a few places, though let's try to avoid needing

Does anyone object to us running this on the source code in git, in
master, soon?

Murray Cumming
murrayc murrayc com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]