Shall private.h files be excluded when .defs files are created?



There are at least two ways of declaring a function private in glib and gtk+:
  • The function name begins with an underscore (_).
  • The function is declared in a file whose name ends with private.h.

The first set of names are excluded by h2def.py and never written to the methods.defs files. The second set of names are included in the methods.defs files, if the private.h files are input data to h2def.py.

I suggest that I change the {glibmm|gtkmm}/tools/gen_scripts/*_generate_{enums|methods}.sh files to exclude private.h files. It's easy with bash's extended pattern matching.

If private.h files are excluded, they ought to be excluded consistently every time the .defs files are regenerated, to avoid some warnings from gmmproc. That will of course be automatic, if those scripts are always used. gmmproc warns for unnecessary _IGNORE directives, and what's unnecessary depends on what's in the methods.defs file.

Kjell



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]