Re: My build_filename() patch
- From: Mark Roberts <gtkmm manumark de>
- To: Fabrício Godoy <skarllot gmail com>
- Cc: gtkmm-list <gtkmm-list gnome org>
- Subject: Re: My build_filename() patch
- Date: Mon, 26 Oct 2009 11:24:05 +0100 (CET)
Dear Fabrício and list,
Fabrício wrote:
I submited a patch in #599578[1].
Thanks.
References:
1- https://bugzilla.gnome.org/show_bug.cgi?id=599578
Your code includes this sort of code a few times:
path = g_build_filename(ustr1.c_str(), ustr2.c_str(), NULLPOINTER);
Glib::ustring r_path(path);
g_free(path);
return r_path;
Surely if out-of-memory, g_build_filename() will return 0 and
ustring::ustring() will throw a bad-argument exception, which the customer
will not understand. We want to throw the no-memory-exception, don't we?
All the best,
Mark
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]