GNOME.org
 

Gtkmm-forge Digest, Vol 36, Issue 10

Send Gtkmm-forge mailing list submissions to
	gtkmm-forge lists sourceforge net

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.sourceforge.net/lists/listinfo/gtkmm-forge
or, via email, send a message with subject or body 'help' to
	gtkmm-forge-request lists sourceforge net

You can reach the person managing the list at
	gtkmm-forge-owner lists sourceforge net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Gtkmm-forge digest..."


gtkmm-forge is the mailing list that receives gtkmm bug reports from bugzilla.  A daily digest is sent to gtkmm-main, to encourage people to help fixing the bugs. Do not try to unsubscribe gtkmm-forge from gtkmm-list.


Today's Topics:

   1. [Bug 582996] goocanvasmm: missing return value
      (gnomemm (bugzilla.gnome.org))
   2. [Bug 582997] Missing return value (gnomemm (bugzilla.gnome.org))
   3. [Bug 582981] an editable TreeViewColumn when a
      TreeModelFilter is used as TreeModel doesn't work properly
      (gtkmm (bugzilla.gnome.org))
   4. [Bug 582439] [PATCH] Fix build on maemo platform
      (gnomemm (bugzilla.gnome.org))
   5. [Bug 582439] [PATCH] Fix build on maemo platform
      (gnomemm (bugzilla.gnome.org))
   6. [Bug 583037] New: Reference counting for return	value of
      Gtk::IconView::get_model() is not proper (gtkmm (bugzilla.gnome.org))
   7. [Bug 582981] an editable TreeViewColumn when a
      TreeModelFilter is used as TreeModel doesn't work properly
      (gtkmm (bugzilla.gnome.org))


----------------------------------------------------------------------

Message: 1
Date: Mon, 18 May 2009 08:59:22 +0000 (UTC)
From: "gnomemm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582996] goocanvasmm: missing return
	value
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518085922 3086123F598 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582996

  gnomemm | goocanvasmm | Ver: unspecified

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from Murray Cumming  2009-05-18 08:59 UTC -------
Fixed in git. Thanks. The .h/cc files are generated from the .hg/.ccg files.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582996.



------------------------------

Message: 2
Date: Mon, 18 May 2009 09:06:45 +0000 (UTC)
From: "gnomemm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582997] Missing return value
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518090645 BCCD323F51F label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582997

  gnomemm | libgdamm | Ver: unspecified

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from Murray Cumming  2009-05-18 09:06 UTC -------
Fixed in git. Thanks.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582997.



------------------------------

Message: 3
Date: Mon, 18 May 2009 09:11:37 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582981] an editable TreeViewColumn when
	a	TreeModelFilter is used as TreeModel doesn't work properly
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518091137 9A8F023F513 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582981

  gtkmm | TreeView | Ver: 2.16.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2009-05-18 09:11 UTC -------
I thought I had fixed this ages ago in this commit:

2004-10-30  Murray Cumming  <murrayc murrayc com>

        * gtk/src/treemodelfilter.[hg|ccg]: Added implementations of 
        set_value_impl() to ouput a warning when it is used instead of 
        the child model. Added const versions of patch convert methods.
        * gtk/src/treeview.[hg|ccg]: Added _get_base_model() non-public API 
        member method to get the child model, if necessary. Used it in the 
        cell renderer signal handlers instead of get_model().
        * Added examples/book/treeview/filter, from the gtkmm-2-4 branch.

Maybe you could investigate why that is not working.

Of course there are only convenience methods, so in the worst case you can just
construct the view columns manually.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582981.



------------------------------

Message: 4
Date: Mon, 18 May 2009 09:22:28 +0000 (UTC)
From: "gnomemm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582439] [PATCH] Fix build on maemo
	platform
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518092228 70AC023F595 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582439

  gnomemm | gstreamermm | Ver: unspecified




------- Comment #16 from Johannes Schmid  2009-05-18 09:22 UTC -------
Regarding the exceptions I have a question:

Bin::add and Bin::remove throw std::exceptions. IMHO it would be better to just
print the message ("Cannot add/remove null element) to stderr when using no
exceptions because this is something usually handled by a g_return_if_fail() in
gtk+.

Doing things like
  bin->add(e1)->add(e2) 
will most likely crash anyway because the exceptions are never catched and this
seems more a check for a programming error than a real use-case for exceptions.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582439.



------------------------------

Message: 5
Date: Mon, 18 May 2009 09:29:47 +0000 (UTC)
From: "gnomemm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582439] [PATCH] Fix build on maemo
	platform
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518092947 53B5623F597 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582439

  gnomemm | gstreamermm | Ver: unspecified




------- Comment #17 from Murray Cumming  2009-05-18 09:29 UTC -------
I think that's OK for a first attempt. You could create a handle_error() method
that had the ifdef only inside there, to keep it simple.

Later we probably do need a version of add() and remove() that take an error
output parameter. That means that the "chaining" syntax can't be used, but I
don't see a way around that.

> Doing things like
>  bin->add(e1)->add(e2) 
> will most likely crash anyway because the exceptions are never catched

Well they should be caught. Please correct any example code that doesn't catch
the exceptions.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582439.



------------------------------

Message: 6
Date: Mon, 18 May 2009 12:52:44 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 583037] New: Reference counting for
	return	value of Gtk::IconView::get_model() is not proper
To: gtkmm-forge lists sourceforge net
Message-ID: <bug-583037-5595 http bugzilla gnome org/>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=583037

  gtkmm | general | Ver: unspecified
           Summary: Reference counting for return value of
                    Gtk::IconView::get_model() is not proper
           Product: gtkmm
           Version: unspecified
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: general
        AssignedTo: gtkmm-forge lists sourceforge net
        ReportedBy: santanu sinha gmail com
         QAContact: gtkmm-forge lists sourceforge net
                CC: debarshi ray gmail com
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please check: http://git.gnome.org/cgit/gtkmm/tree/gtk/src/iconview.hg line:58
Now look at: http://git.gnome.org/cgit/gtkmm/tree/gtk/src/treeview.hg line 124

in iconview.hg the definition should be:
_WRAP_METHOD(Glib::RefPtr<TreeModel> get_model(), gtk_icon_view_get_model,
refreturn)

Due to this the following code will lead to overall application crash:

Item SomeDerivedClassFromIconView::get_item_from_path( 
                                      const Gtk::TreeModel::Path &path )
{
  const TreeViewPtr &model = get_model();
  //Do some thing to get item
  return item;
}

As a work-around we are using:
Item SomeDerivedClassFromIconView::get_item_from_path( 
                                      const Gtk::TreeModel::Path &path )
{
  const TreeViewPtr &model = get_model();
  g_object_ref( model->gobj() );

  //Do some thing to get item
  return item;
}


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=583037.



------------------------------

Message: 7
Date: Mon, 18 May 2009 15:19:57 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 582981] an editable TreeViewColumn when
	a	TreeModelFilter is used as TreeModel doesn't work properly
To: gtkmm-forge lists sourceforge net
Message-ID: <20090518151957 62CFB23F598 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582981

  gtkmm | TreeView | Ver: 2.16.x




------- Comment #3 from Luca Wehrstedt  2009-05-18 15:19 UTC -------
I've tried to workaround the bug by creating the column manually, and by doing
it I think I've discovered what causes it. I'll try to explain it as good as I
can.

When connecting the "toggled" signal to the cellrenderer, the callback function
receives as argument the path of the row, in the form of a ustring.
If it tries to get the iter using the treemodelfilter (by doing
filter->get_iter(path)), it doesn't work and gtkmm prints a warning, I think
because of the changes you've made in the commit you've mentioned above.
If it tries to get the iter using the treemodel on which the treemodelfilter is
based (by doing filter->get_model()->get_iter(path)) it gets the wrong iter,
because the path (which is simply a number) is not referred to that treemodel.
This is the actual behavior of gtkmm, and because of this the bug appears.
If it tries to get the iter using the treemodelfilter, but then it converts it
to a treemodel iter (using filter->convert_iter_to_child_iter) it gets the
right iter and behaves as expected.

Resuming: the bug is related to the fact that the model passed to
TreeView::_auto_store_on_cellrenderer_toggle_edited_with_model is obtained
using TreeView::_get_base_model.
There should be a control inside the first function (or inside the function
which calls it) to check whether the model is a treemodelfilter or not, and, if
it is, to modify the iter opportunely.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582981.



------------------------------

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects

------------------------------

_______________________________________________
Gtkmm-forge mailing list
Gtkmm-forge lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/gtkmm-forge


End of Gtkmm-forge Digest, Vol 36, Issue 10
*******************************************
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]