GNOME.org
 

Gtkmm-forge Digest, Vol 29, Issue 7

Send Gtkmm-forge mailing list submissions to
	gtkmm-forge lists sourceforge net

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.sourceforge.net/lists/listinfo/gtkmm-forge
or, via email, send a message with subject or body 'help' to
	gtkmm-forge-request lists sourceforge net

You can reach the person managing the list at
	gtkmm-forge-owner lists sourceforge net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Gtkmm-forge digest..."


gtkmm-forge is the mailing list that receives gtkmm bug reports from bugzilla.  A daily digest is sent to gtkmm-main, to encourage people to help fixing the bugs. Do not try to unsubscribe gtkmm-forge from gtkmm-list.


Today's Topics:

   1. [Bug 556315] Extra defs generation utility forgets	to
      generate signals for interfaces (glibmm (bugzilla.gnome.org))
   2. [Bug 556315] Extra defs generation utility forgets	to
      generate signals for interfaces (glibmm (bugzilla.gnome.org))
   3. [Bug 556387] New: FileEnumerator::next_file	reference
      counting problems (glibmm (bugzilla.gnome.org))
   4. [Bug 556387] FileEnumerator::next_file reference	counting
      problems (glibmm (bugzilla.gnome.org))
   5. [Bug 556387] FileEnumerator::next_file reference	counting
      problems (glibmm (bugzilla.gnome.org))
   6. [Bug 556387] FileEnumerator::next_file reference	counting
      problems (glibmm (bugzilla.gnome.org))
   7. [Bug 556387] FileEnumerator::next_file reference	counting
      problems (glibmm (bugzilla.gnome.org))
   8. [Bug 556387] FileEnumerator::next_file reference	counting
      problems (glibmm (bugzilla.gnome.org))


----------------------------------------------------------------------

Message: 1
Date: Wed, 15 Oct 2008 09:17:00 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556315] Extra defs generation utility
	forgets	to generate signals for interfaces
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015091700 D0C7223F503 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556315

  glibmm | build | Ver: 2.18.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2008-10-15 09:16 UTC -------
I thought we did this (or maybe just for properties), but it looks good. Please
apply.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556315.



------------------------------

Message: 2
Date: Wed, 15 Oct 2008 09:17:00 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556315] Extra defs generation utility
	forgets	to generate signals for interfaces
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015091700 D0C7223F503 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556315

  glibmm | build | Ver: 2.18.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2008-10-15 09:16 UTC -------
I thought we did this (or maybe just for properties), but it looks good. Please
apply.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556315.



------------------------------

Message: 3
Date: Wed, 15 Oct 2008 09:54:34 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] New: FileEnumerator::next_file
	reference counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <bug-556387-5595 http bugzilla gnome org/>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified
           Summary: FileEnumerator::next_file reference counting problems
           Product: glibmm
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: giomm
        AssignedTo: gtkmm-forge lists sourceforge net
        ReportedBy: armin arbur net
         QAContact: gtkmm-forge lists sourceforge net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The FileEnumerator::next_file method adds an additional reference to the return
value via the refreturn flag to gmmproc, but the C version
g_file_enumerator_next_file() returns a new object with reference count 1, so
there is no need to add an additional reference. This prevents the file
enumerator from being freed correctly when the RefPtr goes out of scope.

Similarly, FileEnumerator::next_files_finish() returns a list with shallow
ownership, but the C documentation says

"You must free the list with g_list_free() and unref the infos with
g_object_unref when you're done with them."

which means we need to set deep ownership for the GFileInfos to get freed
correctly.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

Message: 4
Date: Wed, 15 Oct 2008 09:57:58 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] FileEnumerator::next_file
	reference	counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015095758 955FD23F503 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified




------- Comment #1 from Armin Burgmeier  2008-10-15 09:57 UTC -------
Created an attachment (id=120631)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=120631&action=view)
Test demonstrating the problem

This demonstrates the problem: When using the C++ version of next_file, the
reference count of the resulting GFileInfo object is 2, but it is only 1 using
the C version.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

Message: 5
Date: Wed, 15 Oct 2008 10:07:16 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] FileEnumerator::next_file
	reference	counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015100716 21FB623F502 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified




------- Comment #2 from Armin Burgmeier  2008-10-15 10:07 UTC -------
Created an attachment (id=120632)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=120632&action=view)
Proposed patch

This patch fixes the problem by not adding an extra reference in next_file and
using deep ownership for next_files_finish.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

Message: 6
Date: Wed, 15 Oct 2008 12:17:14 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] FileEnumerator::next_file
	reference	counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015121714 F010823F501 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified

Jonathon Jongsma (jonner) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathon quotidian org
 Attachment #120632|none                        |accepted-commit_now
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #3 from Jonathon Jongsma (jonner)  2008-10-15 12:17 UTC -------
Thanks, this looks good.  Feel free to commit.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

Message: 7
Date: Wed, 15 Oct 2008 12:27:00 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] FileEnumerator::next_file
	reference	counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015122700 C243F23F502 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified

Armin Burgmeier changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120632|accepted-commit_now         |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #4 from Armin Burgmeier  2008-10-15 12:26 UTC -------
Committed.

2008-10-15  Armin Burgmeier  <armin openismus com>

        * gio/src/fileenumerator.hg:
        * gio/src/fileenumerator.ccg: Made FileEnumerator::next_file not add
        an additional reference to the return value, because the C version
        creates a new object. Also, changed ownership of the list returned by
        FileEnumerator::next_files_finish to be deep instead of shallow. Bug
        #556387.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

Message: 8
Date: Wed, 15 Oct 2008 14:44:37 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 556387] FileEnumerator::next_file
	reference	counting problems
To: gtkmm-forge lists sourceforge net
Message-ID: <20081015144437 9B72323F503 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556387

  glibmm | giomm | Ver: unspecified

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #5 from Murray Cumming  2008-10-15 14:44 UTC -------
I guess this isn't documented properly for the C function:
http://library.gnome.org/devel/gio/unstable/GFileEnumerator.html#g-file-enumerator-next-file
Maybe it should say "you should unreference this with g_object_unref()" or
suchlike. Could you file a bug for that, please?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556387.



------------------------------

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

------------------------------

_______________________________________________
Gtkmm-forge mailing list
Gtkmm-forge lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/gtkmm-forge


End of Gtkmm-forge Digest, Vol 29, Issue 7
******************************************
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]