GNOME.org
 

Gtkmm-forge Digest, Vol 27, Issue 17

Send Gtkmm-forge mailing list submissions to
	gtkmm-forge lists sourceforge net

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.sourceforge.net/lists/listinfo/gtkmm-forge
or, via email, send a message with subject or body 'help' to
	gtkmm-forge-request lists sourceforge net

You can reach the person managing the list at
	gtkmm-forge-owner lists sourceforge net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Gtkmm-forge digest..."


gtkmm-forge is the mailing list that receives gtkmm bug reports from bugzilla.  A daily digest is sent to gtkmm-main, to encourage people to help fixing the bugs. Do not try to unsubscribe gtkmm-forge from gtkmm-list.


Today's Topics:

   1. [Bug 549158] Adding recursive_unset to gconfmm
      (gtkmm (bugzilla.gnome.org))
   2. [Bug 549343] New: ustring.cc including config.h	assumes gnu
      tool build (glibmm (bugzilla.gnome.org))
   3. [Bug 547901] Implementing unwrapped copy functions	for
      Glib::NodeTree (glibmm (bugzilla.gnome.org))
   4. [Bug 547901] Implementing unwrapped copy functions	for
      Glib::NodeTree (glibmm (bugzilla.gnome.org))
   5. [Bug 547901] Implementing unwrapped copy functions	for
      Glib::NodeTree (glibmm (bugzilla.gnome.org))
   6. [Bug 547889] Implementing C++ version of GNode	test case for
      Glib:NodeTree (glibmm (bugzilla.gnome.org))
   7. [Bug 547889] Implementing C++ version of GNode	test case for
      Glib:NodeTree (glibmm (bugzilla.gnome.org))


----------------------------------------------------------------------

Message: 1
Date: Mon, 25 Aug 2008 12:02:16 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 549158] Adding recursive_unset to
	gconfmm
To: gtkmm-forge lists sourceforge net
Message-ID: <20080825120216 B914923F517 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=549158

  gtkmm | general | Ver: unspecified

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from Murray Cumming  2008-08-25 12:02 UTC -------
That's great. Thanks. Committed.

I corrected your ChangeLog entry, which should mention a person's name.

I also added a default value for the flags parameter.

This is in gconfmm-2.23.1, which I have just released. That will be in an
API/ABI-stable gconfmm-2.24.0 release when GNOME 2.24 is released soon.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=549158.



------------------------------

Message: 2
Date: Mon, 25 Aug 2008 19:07:44 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 549343] New: ustring.cc including
	config.h	assumes gnu tool build
To: gtkmm-forge lists sourceforge net
Message-ID: <bug-549343-5595 http bugzilla gnome org/>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=549343

  glibmm | build | Ver: 2.16.x
           Summary: ustring.cc including config.h assumes gnu tool build
           Product: glibmm
           Version: 2.16.x
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: build
        AssignedTo: gtkmm-forge lists sourceforge net
        ReportedBy: kovacsp3 comcast net
         QAContact: gtkmm-forge lists sourceforge net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
Hi,

I'm building glibmm-2.16.4 using MS Visual C++ 2008 Express and I can report
that it *does* build, however, I needed to make a minor change to ustring.cc.  

ustring.cc
----------
#include <config.h>

This unconditional include assumes the builder is using gnu build tools.  I
believe the intention there was to make SIZEOF_WCHAR_T visible in the unit.

This breaks MS Visual Studio build as there is no config.h in that context.
Even using the gnu tools, I believe standard form for use of config.h is to use
the guard:

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

Not sure how you might choose to handle SIZEOF_WCHAR_T, i.e. where to define
that, if not in config.h.

Cheers.

Phil

Steps to reproduce:
1. 
2. 
3. 


Actual results:
no such file: config.h error

Expected results:


Does this happen every time?
yes

Other information:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=549343.



------------------------------

Message: 3
Date: Tue, 26 Aug 2008 06:01:57 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547901] Implementing unwrapped copy
	functions	for Glib::NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080826060157 6464923F518 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547901

  glibmm | build | Ver: 2.17.x




------- Comment #5 from Szil?rd Pfeiffer  2008-08-26 06:01 UTC -------
(In reply to comment #4)
> Thanks, but:
> 
> (In reply to comment #3)
> > Created an attachment (id=117227)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=117227&action=view) [edit]
> > modified patch which considers the questions in comment 2
> > 
> > a) copy_deep must construct the C++ wrapper, g_node_copy_deep cannot do that
> 
> I don't see a comment in the constructor about g_node_copy_deep().
I put the comment inside the copy_deep() function.

> 
> I also don't understand why you have added a copy_deep() method. Why shouldn't
> people just use the copy constructor.
They can use both of them. If somebody like the C-like  version he can use
copy_deep(), if he likes the C++ version he can use the copy constructor.

> 
> Also, if there is a copy constructor, surely there should be an operator=()?,
> with them both maybe sharing some code.
> 
Which operator= is on your mind?

 - operator=(const T& data)
   it is not a big deal, but the functionality can be acquired by data()
function
 - operator=(const NodeTree<T>& node)
  What should it mean? Should it change parent/children/next/prev pointers, or
only overwites the data with the copy of node.data()? In my humble opinion it
might be the source of misunderstandings.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547901.



------------------------------

Message: 4
Date: Tue, 26 Aug 2008 06:04:00 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547901] Implementing unwrapped copy
	functions	for Glib::NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080826060400 433D123F518 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547901

  glibmm | build | Ver: 2.17.x

Szil?rd Pfeiffer changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117227|0                           |1
        is obsolete|                            |




------- Comment #6 from Szil?rd Pfeiffer  2008-08-26 06:03 UTC -------
Created an attachment (id=117378)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=117378&action=view)
modified patch related to comment 5 


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547901.



------------------------------

Message: 5
Date: Tue, 26 Aug 2008 13:42:44 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547901] Implementing unwrapped copy
	functions	for Glib::NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080826134244 5296623F52E label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547901

  glibmm | build | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #7 from Murray Cumming  2008-08-26 13:42 UTC -------
Thanks. I have committed that. However:

> > I also don't understand why you have added a copy_deep() method. Why shouldn't
> > people just use the copy constructor.
> They can use both of them. If somebody like the C-like  version he can use
> copy_deep(), if he likes the C++ version he can use the copy constructor.

That doesn't seem sensible. It's a C++ API. Having two ways to do it just
clutters the API and gives the impression that one way does something
different. I removed copy_deep().

> > Also, if there is a copy constructor, surely there should be an operator=()?,
> > with them both maybe sharing some code.
> > 
> Which operator= is on your mind?
> 
>  - operator=(const T& data)
>    it is not a big deal, but the functionality can be acquired by data()
> function
>  - operator=(const NodeTree<T>& node)

This one.

>   What should it mean? Should it change parent/children/next/prev pointers, or
> only overwites the data with the copy of node.data()? In my humble opinion it
> might be the source of misunderstandings.

In general, I think that any copy constructor (not all constructors) should
have a corresponding operator=() because it's not always easy to know when one
or the other will be used, so they should both exist, and should both do the
same thing. I have added that.

I think that's everything, but please reopen if necessary.

Thanks for your work and attention on this.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547901.



------------------------------

Message: 6
Date: Tue, 26 Aug 2008 13:42:44 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547889] Implementing C++ version of
	GNode	test case for Glib:NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080826134244 B9EAA23F58C label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547889

  glibmm | tests | Ver: 2.17.x

Bug 547889 depends on bug 547901, which changed state.

Bug 547901 Summary: Implementing unwrapped copy functions for Glib::NodeTree
http://bugzilla.gnome.org/show_bug.cgi?id=547901

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547889.



------------------------------

Message: 7
Date: Tue, 26 Aug 2008 13:43:16 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547889] Implementing C++ version of
	GNode	test case for Glib:NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080826134316 43F1923F52E label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547889

  glibmm | tests | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from Murray Cumming  2008-08-26 13:43 UTC -------
The whole test case is now uncommented.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547889.



------------------------------

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

------------------------------

_______________________________________________
Gtkmm-forge mailing list
Gtkmm-forge lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/gtkmm-forge


End of Gtkmm-forge Digest, Vol 27, Issue 17
*******************************************
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]