Re: [GtkGLExt] wglinfo on Cygwin
- From: Braden McDaniel <braden endoframe com>
- To: gtkglext-list gnome org
- Subject: Re: [GtkGLExt] wglinfo on Cygwin
- Date: Sun, 14 Nov 2010 03:28:00 -0500
On Sat, 2010-11-13 at 10:59 +0000, John Darrington wrote:
> Using the latest HEAD 98ffc0d8a3ac5eb5e62f30cdb90305e132d5fd4f
> I cannot build the wglinfo program in the examples directory.
>
> Since it appears to be full of stuff specific to Windoze, I think
> the following patch is appropriate:
>
>
> diff --git a/examples/Makefile.am b/examples/Makefile.am
> index 40378fd..a8beb6d 100644
> --- a/examples/Makefile.am
> +++ b/examples/Makefile.am
> @@ -167,7 +167,7 @@ endif
> endif
> endif
>
> -if PLATFORM_WIN32
> +if USE_WIN32
> noinst_PROGRAMS += wglinfo
> wglinfo_SOURCES = wglinfo.c
> wglinfo_LDADD = $(GL_LIBS) $(WINDOWING_LIBS)
Yeah, I think this is correct...
PLATFORM_WIN32 is true for cygwin and mingw environments.
USE_WIN32 is true when building with the GTK+ Win32 backend.
So there are definitely instances where PLATFORM_WIN32 could be true
while USE_WIN32 is false (building against X11 on Windows, most likely).
Due to the Win32 API calls in that example, USE_WIN32 is what we ought
to be using there. In fact, I think USE_WIN32 should replace all
instances of PLATFORM_WIN32 in examples/Makefile.am.
Furthermore... The only other places we're using PLATFORM_WIN32 is to
apply the libtool argument "-no-undefined" conditionally. I don't know
of a reason why we shouldn't just apply "-no-undefined" everywhere and
get rid of PLATFORM_WIN32.
--
Braden McDaniel <braden endoframe com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]