Re: adding gtkdatabox_region

[Matt Flax <flatmax mimosaacoustics com>]

here is my git diff.

I have added the new feature to the basics2.c example. Run it to see it in action !

I decided the best way to approach the new feature is :
a] To call the new plotting feature offset_bars : Bars which start at Y1 and end at Y2
b] To create a new XYYC graph type ... called gtkdatabox_xyyc_graph which handles X, Y1 and Y2. This approach leaves all of the other XYC graphs and plotting methods intact. It is also logical because for each X ordinate we have two Y co-ordinates to draw a line from and to.
c] I found a redundant variable in  _GtkDataboxXYCGraphPrivate. The GdkPoint * is never used ... does anyone know where it is used ? I have removed it and the 'free' call.

What do you think ?
Is there a better name for the new feature ?

Matt

On 24/02/12 05:55, Brian Phelps wrote:

Looks interesting.  DO you have a patch?  t

Sent from my 4G etch-a-sketch.

On Thu, Feb 23, 2012 at 1:05 AM, Matt Flax <flatmax mimosaacoustics com> wrote:

Hi there,

I would like to add a new type of graph to gtkdatabox.

What do you think of a gtkdatabox_region type of graph ? See the attachment.

It would let you plot a region of colour on the graph - similar to the gtkdatabox_bars graph, however allowing two Y points for each X.
In this way, a region of colour may be plotted.
Currently gtkdatabox_bars sets the bar region like so :
      data->x1 = data->x2 = gtk_databox_value_to_pixel_x (box, *X);

      data->y1 = zero;

      data->y2 = gtk_databox_value_to_pixel_y (box, *Y);

I would think that the gtkdatabox_region graph would do something like this instead :
      data->x1 = data->x2 = gtk_databox_value_to_pixel_x (box, *X);

      data->y1 = gtk_databox_value_to_pixel_y (box, *Y2);

      data->y2 = gtk_databox_value_to_pixel_y (box, *Y);


What do you think ?

I have already tested this method and it is attached.

Matt

p.s. I previously posted this message, but the attachment was too large, so I am resending with a smaller attachment.

_______________________________________________
gtkdatabox-list mailing list
gtkdatabox-list gnome org
http://mail.gnome.org/mailman/listinfo/gtkdatabox-list

Attachment: gtkdatabox_offset_bars.diff.bz2
Description: application/bzip