Re: [PATCH] Link against GIO_LIBS explicitly

["Daniel P. Berrange" <dan berrange com>]

On Fri, Feb 10, 2017 at 02:27:48PM +0100, Guido Günther wrote:
> to avoid
>
> libtool: link: gcc -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 
> -fdebug-prefix-map=/build/gtk-vnc-0.6.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z 
> -Wl,relro
>  -Wl,-z -Wl,now -o .libs/vncconnectiontest vncconnectiontest-vncconnectiontest.o  ./.libs/libgvnc-1.0.so 
> -lz -pthread
> /usr/bin/ld: vncconnectiontest-vncconnectiontest.o: undefined reference to symbol 
> 'g_io_stream_get_output_stream'
> //usr/lib/x86_64-linux-gnu/libgio-2.0.so.0: error adding symbols: DSO missing from command line
>
> Also make the use of *_CFLAGS and *_LIBS match.
> ---
>  src/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index f7c1d9d..8bc9085 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -317,8 +317,8 @@ BUILT_SOURCES += $(MARSHAL_FILES) $(ENUM_FILES)
>  CLEANFILES = $(MARSHAL_FILES) $(ENUM_FILES)
>  
>  vncconnectiontest_SOURCES = vncconnectiontest.c
> -vncconnectiontest_CFLAGS = $(GOBJECT_CFLAGS)
> -vncconnectiontest_LDADD = libgvnc-1.0.la
> +vncconnectiontest_CFLAGS = $(GOBJECT_CFLAGS) $(GIO_CLFAGS)

Typo in the last var name, but I've fixed that and pushed to git

> +vncconnectiontest_LDADD = libgvnc-1.0.la $(GOBJECT_LIBS) $(GIO_LIBS)
>  
>  if WITH_PYTHON
>  pyexec_LTLIBRARIES = gtkvnc.la

Regards,
Daniel
--
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|