Re: [PATCH v5] Add support for LED state extension to gvnc

["Daniel P. Berrange" <dan berrange com>]

On Thu, May 09, 2013 at 10:29:11PM +0800, Lei Li wrote:
> Hi guys,
>
> As we are trying to add LED state extension to VNC protocol, and
> the implementation for Qemu VNC server has already upstream. We'd
> like to send out this patch, which tries to add support to gvnc,
> please let me know if there is anything need to be addressed.
>
> The proposal and patch series for detail:
>
> https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg04990.html
>
> Thanks!
>
> Changes since v4:
>   Make the constants statisfy naming convention suggested by Daniel.
>
> Changes since v3:
>   Fix the wrong naming of constants.
>
> Changes since v2:
>   Address comments from Daniel includes:
>     - Include ledstate related constants.
>     - Indentation fix.
>     - Add new callback vnc_led_state() at the end, and remove the
>       corresponding amount of padding.
>
> Changes since v1:
>   Add signal callback vnc_led_state().
>
> Signed-off-by: Lei Li <lilei linux vnet ibm com>
> ---
>  src/libgvnc_sym.version |    1 +
>  src/vncconnection.c     |   44 ++++++++++++++++++++++++++++++++++++++++++++
>  src/vncconnection.h     |   10 +++++++++-
>  3 files changed, 54 insertions(+), 1 deletions(-)

Thanks, I have applied this vesion.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|