GNOME bug #667396: enable gvncviewer to connect to unix domain sockets



Hi gtk-vnc folks--

On 01/10/2012 06:04 AM, Guido Günther wrote:
> On Fri, Jan 06, 2012 at 02:18:48AM -0500, Daniel Kahn Gillmor wrote:
>> gvncviewer can't currently connect to VNC servers running over unix
>> domain sockets, such as those provided by the qemu and kvm utilities.
>>
>> The attached patch enables this feature.  It should apply cleanly at
>> the end of the current patch series in gvncviewer 0.5.0-2.
>>
>> The logic is: test the provided hostname to see if a matching file exists and
>> is a unix-domain socket.  If it is, try to connect to it that way.  otherwise,
>> proceed with argument parsing and TCP sockets as usual.
>>
>> I've also filed this with upstream at:
>>
>>   https://bugzilla.gnome.org/show_bug.cgi?id=667396
> 
> Patch looks good to me. I'd feel even more comfortable applying it, if
> it went in upstream. The upstream list is gtk-vnc-list gnome org and
> usually get's quicker responses than the bugtracker.

Any thoughts about connecting to unix domain sockets from gvncviewer
(GNOME bug 667396)?

I'm not subscribed to this list, so please CC me.  Thanks!

If you have any criticisms or suggestions about what might make the
patch more appealing/acceptable to you, i'd be happy to hear them.

Regards,

	--dkg

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]