Re: [PATCH] Clear reused error variable



On Tue, Sep 07, 2010 at 10:26:57PM +0200, Guido Günther wrote:
> Hi,
> 
> vnc_connection_connect_socket reuses an error variable without clearing
> it (issued by g_socket_connect in vnc_connection_connect_socket):
> 
> (gvncviewer:20406): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory.
> This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
> The overwriting error message was: Connection in progress
> Failed to connect to server

Looks, good. Applied to GIT

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]