Re: [patch] Allows linking with gtk+2.0 and gtk+3.0

[Jonh Wendell <jwendell gnome org>]

Em Qua, 2010-06-30 às 12:46 +0100, Daniel P. Berrange escreveu:

> >  	default:
> >  		g_assert_not_reached ();
> >  	}
> >  
> > +	#if GTK_CHECK_VERSION (2, 90, 0)
> > +	fmt.byte_order = gdk_visual_get_byte_order (v) == GDK_LSB_FIRST ? G_BIG_ENDIAN : G_LITTLE_ENDIAN;
> > +	#else
> > +	fmt.byte_order = v->byte_order == GDK_LSB_FIRST ? G_BIG_ENDIAN : G_LITTLE_ENDIAN;
> > +	#endif
> > +
> 
> The API docs say this method is 'Since 2.22', so why is the check
> doing 2.90 instead of 2.22 ?

We rely on gtk+ 2.18 right now. I think our next big step would be to
rely on gtk+3. IMHO there's no point in depend on gtk+ 2.22 in the
future when we can safely upgrade to gtk+ 3.0.

So, my thought was: either we depend on gtk 2.18 or 3.0. No middle term.

Makes sense?
-- 
Jonh Wendell
http://www.bani.com.br