Re: plugin build is broken

["Daniel P. Berrange" <dan berrange com>]

On Wed, Oct 21, 2009 at 02:30:46PM -0300, Jonh Wendell wrote:
> Hello, folks.
> 
> It was reported that the plugin fails to build:
> https://bugzilla.gnome.org/show_bug.cgi?id=599146
> 
> The attached patch (trivial) fixes the build in my machine, however I
> would like to know why this fails now but built fine before.
> 
> Also, it was suggested to drop the plugin from the source [1]. What are
> the plans?

Well the stability problems really ought to be fixable - after all
Totem uses GTK and works pretty reliably as a plugin.

For the security issue, it is definitely an problem if the plugin will
automatically connect to any page including a HTMl snippet. Thus I'd
be inclined to say it should be changed to only display a small button,
plus label detailing what site will be connected to. That way it won't
connect to sites without the user realizing.


> diff --git a/plugin/Makefile.am b/plugin/Makefile.am
> index 2fa8777..1bd70c3 100644
> --- a/plugin/Makefile.am
> +++ b/plugin/Makefile.am
> @@ -12,7 +12,7 @@ gtk_vnc_plugin_la_LDFLAGS = \
>  	-module -avoid-version
>  gtk_vnc_plugin_la_CFLAGS = \
>  	-I$(top_srcdir)/src @GTK_CFLAGS@ \
> -	@FIREFOX_PLUGIN_CFLAGS@ @WARNING_CFLAGS@ @WERROR_CFLAGS@
> +	@FIREFOX_PLUGIN_CFLAGS@ @WARNING_CFLAGS@
>  
>  all-local: gtk-vnc-plugin.so
>  

ACK


Daniel
-- 
|: http://berrange.com/     -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://freshmeat.net/~danielpb/    -o-   http://gtk-vnc.sourceforge.net :|