Re: [gtk-vnc-devel] [PATCH] [virt-viewer] Allow cross-compilation under MinGW

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Oct 09, 2008 at 05:25:35PM +0100, Richard W.M. Jones wrote:
> This is a fairly conservative patch which enables virt-viewer to build
> cross-compiled under MinGW, and probably also enables it to build on
> Windows itself (though this latter thing is not tested).
> 
> The patch contains:
> 
>  - a replacement for the usleep function if it is not available
> 
>  - disables the SSH tunnel if the platform lacks fork and socketpair
> 
> It would probably be possible to reenable SSH tunnels from Windows
> machines, using some special replacement code that called Create-
> Process, but it's not so likely that Windows users have SSH set up.

For the SSH stuff to be useful in the context of virt-viewer, we'd
need to get the SSH stuff working in libvirt first, so its fine to
disable it here.

The patch is impressively small & all looks correct to me, so ACK
to this - though we'll actually want to increment the gtk-vnc
version number dep to 0.3.8 (once we release that version of gtk-vnc
with mingw support).

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|