Re: [gtk-vnc-devel] PATCH: Avoid automake portability warnings



Daniel P. Berrange wrote:
If you use a fairly recent automake when building gtk-vnc you'll probably
see it complain bitterly about us using GNU Make-isms in our makefiles.
This patch adjusts configure.ac to make automake shut up. The key is to
pass the '-Wno-portability' option to automake - the patch is rather large
becasue todo this we need to use new style macros

Looks fine ot me.

Regards,

Anthony Liguori

Dan.


diff -r fb8ab9818527 configure.ac
--- a/configure.ac	Fri Mar 07 11:24:19 2008 -0600
+++ b/configure.ac	Fri Mar 07 12:46:54 2008 -0500
@@ -1,7 +1,11 @@ dnl Process this file with autoconf to p
 dnl Process this file with autoconf to produce a configure script.
-AC_INIT([gtk-vnc], [0.3.4], [anthony codemonkey ws])
-AC_CONFIG_SRCDIR([src/gvnc.c])
+AC_INIT(gtk-vnc, 0.3.4)
+AC_CONFIG_SRCDIR(src/gvnc.c)
+AC_CONFIG_HEADERS([config.h:config.hin])
+dnl Make automake keep quiet about wildcards & other GNUmake-isms
+AM_INIT_AUTOMAKE([-Wno-portability])
+AC_CANONICAL_HOST
GTK_REQUIRED=2.0.0
 AC_SUBST(GTK_REQUIRED)
@@ -20,14 +24,6 @@ FIREFOX_PLUGIN_REQUIRED=2.0.0
 FIREFOX_PLUGIN_REQUIRED=2.0.0
 MOZILLA_PLUGIN_REQUIRED=1.8
-
-AC_CONFIG_HEADERS([config.h:config.hin])
-
-
-AC_CANONICAL_TARGET
-
-AM_INIT_AUTOMAKE(gtk-vnc, 0.3.4)
-
 AC_PROG_CC_STDC
 AM_PROG_CC_C_O
 AC_PROG_LIBTOOL







[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]