Re: [gtk-vnc-devel] [PATCH] fix the parameter type of vnc-auth-credentials

[Anthony Liguori <anthony codemonkey ws>]

I thought I tried a similar fix to yours and convinced myself there was 
no way to get it working.  I tried your patch though and it worked for 
me so now I'm unsure.

I need to investigate the issue further.  I'll figure out for sure this 
weekend and let you know when I commit the patch.

Regards,

Anthony Liguori

Saori Fukuta wrote:
> Hello,
>
> I get the following 'TypeError' with Upstream gtk-vnc (Cset:145)
> when I try to connect to server by using examples/gvnviewr.py.
>   # ./gtk-vnc.hg/examples/gvncviewer.py 127.0.0.1:10
>   Connecting to 127.0.0.1 5910
>   Connected to server
>   Traceback (most recent call last):
>     File "./gtk-vnc.hg/examples/gvncviewer.py", line 66, in vnc_auth_cred
>       for i in range(len(credList)):
>   TypeError: object of type 'gobject.GPointer' has no len()
>
> On the other hand, 'gvncviewer' made by gvncviewer.c works.
>   # ./gtk-vnc.hg/examples/gvncviewer 127.0.0.1:10
>   Connected to server
>   Got credential request for 1 credential(s)
>   Remote desktop size changed to 640x480
>   Connection initialized
>   --> succeeded in connecting
>
> So, I guess there is a problem with the type of 'credList'
> when that is used by python.
>
> At Cset:127, Anthony changed the c_marshaller of vnc-auth-credentials 
> from PARAM to POINTER, and also the parameter types changed from
> G_TYPE_VALUE_ARRAY to G_TYPE_POINTER.
> http://gtk-vnc.codemonkey.ws/hg/outgoing.hg/rev/a720c8172a85
> Do we need to change the parameter type ?
>
> If not needed, could you revert the type by this patch ?
> ----
> diff -r 777ee6d6a72d src/vncdisplay.c
> --- a/src/vncdisplay.c  Fri Feb 08 21:30:38 2008 -0300
> +++ b/src/vncdisplay.c  Thu Feb 14 14:36:38 2008 +0900
> @@ -1643,7 +1643,7 @@ static void vnc_display_class_init(VncDi
>                               g_cclosure_marshal_VOID__POINTER,
>                               G_TYPE_NONE,
>                               1,
> -                             G_TYPE_POINTER);
> +                             G_TYPE_VALUE_ARRAY);
>
>
>         signals[VNC_POINTER_GRAB] =
>
> Signed-off-by: Saori Fukuta <fukuta saori jp fujitsu com>
>
> Regards,
> Saori Fukuta
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Gtk-vnc-devel mailing list
> Gtk-vnc-devel lists sourceforge net
> https://lists.sourceforge.net/lists/listinfo/gtk-vnc-devel
>