Re: [gtk-vnc-devel] [PATCH] gtkgl based scaling



Daniel P. Berrange wrote:
On Sat, Feb 02, 2008 at 02:16:42PM -0600, Anthony Liguori wrote:
I've just committed this patch (it's not in the 0.3.3 release). Please try it out and let me know what you think.

I've modified gvncviewer so that it has a Full Screen and OpenGL Scaling menu option. The dependency on gtkglext is optional and there's also a new optional dependency on libview. This is only used by gvncviewer though so I do not recommend that any distro packages make gtk-vnc depend on libview.

The gtkglext stuff seems to be working prertty nicely - it even works on my
r500 ATI card where I don't even have 3d X driver support, or even 2d accel!

Sometimes though it does not refresh the screen properly. Asan exmaple, if i'm using a xterm and say type 'pwd<enter>', i'll see the 'pwd' characters typed, but not the newline and not the command output - until I type another character or move the mouse. So it seems the screen refreshs may be getting delayed somehow.

Yeah, that reminds me, I saw that on another machine with an ATI graphics card. Since I can reproduce it, I'll figure out what the problem is. It doesn't happen on my Intel laptop so I've forgotten about it :-)

Given that it works at an acceptable speed even without an accelerated X
driver I figure we ought to automatically enable it if the configure script
finds the neccessary library.

My only thinking was that I didn't want to break applications since the scaling is based on the widget size but you may be right.

FWIW, I did some benchmarking on my laptop. Watching a dvd over VNC, scaling by almost double only increased cpu consumption from about 81% to 85% so I'm really happy with the accelerated performance.

Regards,

Anthony Liguori

Regards,
Dan.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]