Re: [gtk-vnc-devel] [patch] - Use GLib memory functions

["Richard W.M. Jones" <rjones redhat com>]

On Fri, Apr 11, 2008 at 03:37:23PM +0100, Daniel P. Berrange wrote:
> I'm not so sure about that. The size of the data we're mallocing is often
> being generated based on data from the remote server messages. eg, mallocing
> a block based on the size of the framebuffer update. The server could thus
> send bogus size and trick us into mallocing data for a 65536x65536 update 
> and cause malloc to fail and the app to crash. With the current scheme of
> checking malloc we'd merely terminate the VNC connection and not crash
> which i think is nicer behaviour.

And in addition, this is much nicer behaviour when "the application"
is your browser -- think browser plugin.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top