Re: [gtk-vnc-devel] PATCH: Fix opengl rendering z-buffer depth

[Anthony Liguori <anthony codemonkey ws>]

Daniel P. Berrange wrote:
> On Thu, Apr 03, 2008 at 07:17:03PM -0500, Anthony Liguori wrote:
>   
> > Daniel P. Berrange wrote:
> >     
> > > diff -r 6f18ca44fbe3 examples/gvncviewer.c
> > > --- a/examples/gvncviewer.c	Thu Apr 03 12:57:25 2008 -0300
> > > +++ b/examples/gvncviewer.c	Thu Apr 03 14:23:16 2008 -0400
> > > @@ -339,7 +339,8 @@
> > > 	submenu = gtk_menu_new();
> > >
> > > 	fullscreen = gtk_check_menu_item_new_with_mnemonic("_Full Screen");
> > > -	scaling = gtk_check_menu_item_new_with_mnemonic("OpenGL _Scaling");
> > > +	scaling = gtk_check_menu_item_new_with_mnemonic("Scaled display");
> > > +	gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(scaling), TRUE);
> > >
> > > 	gtk_menu_append(GTK_MENU(submenu), fullscreen);
> > > 	gtk_menu_append(GTK_MENU(submenu), scaling);
> > > @@ -369,6 +370,7 @@
> > > 	vnc_display_open_host(VNC_DISPLAY(vnc), hostname, port);
> > > 	vnc_display_set_keyboard_grab(VNC_DISPLAY(vnc), TRUE);
> > > 	vnc_display_set_pointer_grab(VNC_DISPLAY(vnc), TRUE);
> > > +	vnc_display_set_scaling(VNC_DISPLAY(vnc), TRUE);
> > >
> > > 	gtk_signal_connect(GTK_OBJECT(window), "delete-event",
> > > 			   GTK_SIGNAL_FUNC(gtk_main_quit), NULL);
> > >  
> > >       
> > Can we do the composite check here instead of unconditionally enabling 
> > scaling.  That shows people what the right thing to do is (along with 
> > making gvncviewer still work with compositing).
> >     
>
> Yes, good point. Will do that.
>
> BTW, in Fedora 9, with Intel graphics redirected direct rendering is now
> working.
>
> http://hoegsberg.blogspot.com/2008/03/i-just-committed-last-bit-of-dri2-work.html
>
> Its a little unstable (ie hangs/crashes X), but you can have compiz enabled
> GTK-VNC scaling and spinning on a cube all rendering beautifully!
>   

Very cool!

Regards,

Anthony Liguori

> Dan.
>