Re: [gtk-vnc-devel] Suncc generate bad macro defination for blt.h

[Halton Huo <Halton Huo Sun COM>]

Thanks for accepting the patch.

I did not get the change after I run 'hg up'.

Halton.
On Fri, 2007-10-26 at 15:02 +0100, Daniel P. Berrange wrote:
> On Fri, Oct 26, 2007 at 08:56:01AM -0500, Anthony Liguori wrote:
> > Halton Huo wrote:
> > > Hi there,
> > >
> > > I'm trying to build gtk-vnc trunk code on Solaris using suncc, but met 
> > > error message as following:
> > > $/ws/onnv-tools-prc/SUNWspro/SS11/bin/cc -DHAVE_CONFIG_H -I. -I.. 
> > > -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include 
> > > -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 
> > > -I/usr/X11/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
> > > -I/usr/sfw/include -I/usr/sfw/include/freetype2 
> > > -I/usr/include/libpng12 
> > > -DSYSCONFDIR=\"/export/home/halton/work/dist/etc\" -I/usr/include/ast 
> > > -g -c gvnc.c  -KPIC -DPIC -o .libs/libgtk_vnc_1_0_la-gvnc.o
> > > "blt.h", line 9: syntax error before or at: uint8
> > > "blt.h", line 9: warning: undefined or missing type for: uint8
> > >
> > > When I generate with "-E" and grep gvnc_fill_fast_, it give me
> > > static void  gvnc_fill_fast_8x8 ( struct gvnc * gvnc , uint8 _t * sp ,
> > >                          gvnc_fill_fast_8x8 ( gvnc , bg , x , y , 
> > > width , height );
> > >                                          gvnc_fill_fast_8x8 ( gvnc , fg ,
> > > static void  gvnc_fill_fast_8x16 ( struct gvnc * gvnc , uint8 _t * sp ,
> > >                          gvnc_fill_fast_8x16 ( gvnc , bg , x , y , 
> > > width , height );
> > >                                          gvnc_fill_fast_8x16 ( gvnc , fg ,
> > >
> > > suncc generate "uint8 _t" instead of "uint8_t", while gcc does well. 
> > > Too bad.
> > >
> > > I've asked suncc email, no response yet.
> > >
> > > Now I found a method to make suncc and gcc work both, and have a patch 
> > > now,
> > > please check the attachment.
> > 
> > Please add a comment too since that appears to be a work around for a 
> > broken preprocessor.
> 
> I've already committed this to the repo with a suitable comment about it
> being a workaround.
> 
> Regards,
> Dan.