Re: [gtk-vnc-devel] [PATCH] Add an interface for sending raw key presses

["Daniel P. Berrange" <berrange redhat com>]

On Fri, Oct 26, 2007 at 08:53:46AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >On Wed, Oct 24, 2007 at 02:43:21PM -0300, Jonh Wendell wrote:
> >  
> >>Em Qua, 2007-10-24 às 12:32 -0500, Anthony Liguori escreveu:
> >>    
> >>>It may be possible to unify the interface though.  Maybe by having a 
> >>>second parameter to send_keys that was the event type.  Possible event 
> >>>types would be PRESS, RELEASE, CLICK.
> >>>      
> >>Yeah, perhaps it could have this signature:
> >>
> >>send_keys (keys, size, flag)
> >>
> >>where flag would be some combination of PRESS and RELEASE.
> >>For instance, PRESS|RELEASE is the current behavior of send_keys().
> >>    
> >
> >Yes, this would work. Do we add a second method to keep ABI, or change the
> >first...
> >  
> 
> Do we care about ABI yet?  Has anyone shipped gtk-vnc in a distro release?

Virt-manager and Vinagre are both using it in Fedora :-) That said, neither
use the send_keys method yet, so we could get away with changing it


Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|