Re: [gtk-vnc-devel] [PATCH][RFC] Enhance gvncviewer a bit



On Wed, Jul 18, 2007 at 11:15:57PM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >On Wed, Jul 18, 2007 at 09:55:51PM -0500, Anthony Liguori wrote:
> >  
> >>I maintain a small program that uses libgtkvnc that I use to connect to 
> >>virtual machines so I get all the neat VNC extensions.  I noticed that 
> >>gvncviewer is pretty close to what I have so I figured I'd just add a 
> >>few more things to gvncviewer.
> >>    
> >
> >Sounds like a good idea - the reason I wrote the gvncviewer mini app was
> >precisely to let me test all the features of the viewer widget too :-)
> >
> >  
> >>The only thing I think may be contentious in this patch is that it's 
> >>installed by default.  If anyone knows a way that make install in 
> >>examples/ would still work but it not be part of a top level make 
> >>install, I'd rather do that.  Alas, my autoconf skills are not very good.
> >>    
> >
> >How about if we added flag to configure so if one did
> >
> >  ./configure --with-examples
> >
> >then a regular top level 'make install' would install the example programs 
> >into $prefix/bin
> >  
> 
> Works for me.  Do you know what the automake foo would be for that?


You should be able to use something like this...

In the configure.ac script

  AC_ARG_WITH(examples, AC_HELP_STRING([--with-examples],
              [install example programs]))

  AM_CONDITIONAL(WITH_EXAMPLES, test "$with_examples" = "yes")

And in the Makefile.am

  if WITH_EXAMPLES
    bin_PROGRAMS = gvncviewer
  else
    noinst_PROGRAMS = gvncviewer
  endif

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]