Re: [gtk-vnc-devel] [PATCH] ZRLE Encoding support

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Dec 27, 2007 at 09:10:16PM -0600, Anthony Liguori wrote:
> Hi,
> 
> Attached is a patch for gtk-vnc to enable the ZRLE encoding.  ZRLE is a 
> compressed encoding that's documented in the RFB specification.  While 
> not as popular as Tight, since it's the "official" compressed encoding 
> for RFB I thought it was a good place to start.

Yeah, good to aim for full support of the base level spec as well as common
extensions.

> This adds a dependency on zlib.  I don't think that's a big deal 
> though.  I'd appreciate if someone could look over my configure.ac 
> change to make sure that's the reasonable thing to do.

No problem with the configure stuff. Just need to add a 

   BuildRequires: zlib-devel

to the gtk-vnc.spec.in file for the RPM build.

> I'd like to commit this before the next release (which I'll do before 
> Monday) so please give it a try and let me know if it works for you.

I've not tested it, but the code looks reasonable to me.

Dan,
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|