Re: [gtk-vnc-devel] PATCH: Clear areas outside of framebuffer region

["Daniel P. Berrange" <berrange redhat com>]

On Wed, Aug 22, 2007 at 03:19:35PM -0300, Jonh Wendell wrote:
> 
> Em Qua, 2007-08-22 às 17:52 +0100, Daniel P. Berrange escreveu:
> > If the GTK-VNC widget gets resized to be larger than the region taken up
> > by the remote framebuffer, the excess space just gets filled with random
> > garbage.  This is seen in Vinagre if you hit "Full Screen"
> > 
> > The attached patch calls gdk_draw_rectangle to fill the excess space with
> > a solid colour (black). It uses a clip mask to ensure we don't clear the
> > space where the actual framebuffer is & thus avoids flickr that would entail.
> 
> The patch worked fine to me.
> 
> BTW, What do you think about putting the widget in the middle of area,
> instead of top left?

It would complicate the drawing code :-)  Can you put the vnc widget
inside the GTK alignment widget and let the alignment do the centering ?

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|