Re: Variant tests failing on big endian machines



On 26.06.2015 17:54, Rafael dos Santos wrote:
const char * g_variant_classify (GVariant *value);
    PREINIT:
        GVariantClass vclass;
    CODE:
        vclass = g_variant_classify (value);
        RETVAL = (const char *) &((char) vclass);

GVariant.xs: In function ‘XS_Glib__Variant_classify’:
GVariant.xs:285:26: error: lvalue required as unary ‘&’ operand
  RETVAL = (const char *) &((char) vclass);
                          ^

Right.  How about this patch then?  Works on my (little-endian) machine.

(The "const char *" typemap copies the string, so it's OK to return
references to local variables.)

Attachment: 0001-WIP.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]