Re: Fwd: [rt.cpan.org #83490] options.t fails for non-utf8 locale

[intrigeri <intrigeri debian org>]

Hi,

Brian Manning wrote (24 Jun 2013 06:57:12 GMT) :
> Here's another patch to try and fix this.  I tested using the following
> LANG/LC_ALL settings: [...]

Thank you.

> Please let me know if you have any questions. I can push a new release of
> Glib in the next few days if I get positive feedback about this fixing the
> test failures.

In my Debian packages build chroot, CODESET == ANSI_X3.4-1968, which
this updated patch does not know about, so the tests still fail.

According to nl_langinfo(3), this is just another name for us-ascii:

  CODESET (LC_CTYPE)
     Return  a string with the name of the character encoding used in
     the  selected  locale,  such  as   "UTF-8",   "ISO-8859-1",   or
     "ANSI_X3.4-1968"  (better  known as US-ASCII).

If I change the patch to read:

        if ( $codeset eq 'US-ASCII' || $codeset eq 'ANSI_X3.4-1968' || $codeset =~ /ISO8859/ );

... instead of:

        if ( $codeset eq 'US-ASCII' || $codeset =~ /ISO8859/ );

... then the tests pass.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc