Re: Gtk2 1.201 available

[Torsten Schoenfeld <kaffeetisch gmx de>]

Sergei Steshenko wrote:

> 'make test' indeed does not fail now, however, I see these messages:
>
> "
> t/GtkDialog........................Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' 
> failed at t/GtkDialog.t line 74.
> Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' failed at t/GtkDialog.t line 74.
> Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' failed at t/GtkDialog.t line 75.
> Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' failed at t/GtkDialog.t line 75.
> Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' failed at t/GtkDialog.t line 75.
> Gtk-CRITICAL **: gtk_box_reorder_child: assertion `GTK_IS_WIDGET (child)' failed at t/GtkDialog.t line 75.
> ok
> ".
>
> Are they expected to be ?

I certainly don't see those.  But if I had to guess, I'd say these are due to 
the dialog being already destroyed when we call set_alternative_button_order() 
on it.  Does the attached patch fix the assertions for you?

-Torsten

Index: GtkDialog.t
===================================================================
--- GtkDialog.t (revision 2076)
+++ GtkDialog.t (working copy)
@@ -71,9 +71,9 @@ SKIP: {
        skip 'set_alternative_button_order is new in 2.6', 3
                unless Gtk2->CHECK_VERSION (2, 6, 0);
 
-       $d3->set_alternative_button_order (2, 3);
-       $d3->set_alternative_button_order (qw(ok cancel accept), 3);
-       $d3->set_alternative_button_order;
+       $d2->set_alternative_button_order (2, 3);
+       $d2->set_alternative_button_order (qw(ok cancel accept), 3);
+       $d2->set_alternative_button_order;
 
        my $screen = Gtk2::Gdk::Screen->get_default;
        like (Gtk2->alternative_dialog_button_order ($screen), qr/^(?:1|)$/);