Re: signal functions in a package module file



Kevin Ryde wrote:
hide_on_delete() is mostly a C convenience function because C does not
have closures: I wouldn't bind that inside an high-level language that
does have them.

Don't forget the principle "why can't someone else do it" -- as
Springfield's most famous sanitation inspector said.  I for instance
have to check almost every time whether it's true or false to propagate
/ not propagate.

I don't have much of an opinion about wrapping gtk_widget_hide_on_delete.  muppet?

What about adding new constants DO_PROPAGATE and DO_NOT_PROPAGATE to Glib, though?

Either way perhaps some words in the docs would be an idea, per below.

I changed the reference to Gtk2::Widget::hide_on_delete to use a closure,
since we don't have the former yet.  Committed to both branches.  Thanks!

-- 
Bye,
-Torsten
Index: Glib.pm
===================================================================
RCS file: /cvsroot/gtk2-perl/gtk2-perl-xs/Glib/Glib.pm,v
retrieving revision 1.122
diff -u -d -p -u -r1.122 Glib.pm
--- Glib.pm     22 Jun 2008 16:58:18 -0000      1.122
+++ Glib.pm     3 Aug 2008 13:26:32 -0000
@@ -30,6 +30,8 @@ our @ISA = qw(DynaLoader Exporter);
 use constant {
        TRUE  => 1,
        FALSE => !1, # can't use !TRUE at this point
+       DO_PROPAGATE => 0,
+       DO_NOT_PROPAGATE => 1,
        G_PRIORITY_HIGH         => -100,
        G_PRIORITY_DEFAULT      =>  0,
        G_PRIORITY_HIGH_IDLE    =>  100,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]