Re: Strange bug

[muppet <scott asofyet org>]

On Thu, 2003-11-20 at 17:20, Bjarne Steinsbà wrote:

> NOW WAIT A MINUTE!
>
> Isn't that ternary going exactly the opposite direction of what it is 
> supposed to?  That is, shouldn't it be:
>
> #define SvGdkBitmap_ornull(sv)        (((sv) && SvTRUE (sv)) ? 
> SvGdkBitmap(sv) : NULL)

/me hangs head in shame.  yes, i got that backwards.  was paying
attention, but the braino was more powerful.

the code it replaces it not backwards, mind you, but only allows actual
undef rather than an undefined value.  in reference to your previous
question of why SvTRUE instead of SvOK, i wasn't sure at the time that
SvOK got definedness.


> BTW, there is another suspicious test for PL_sv_undef in Glib/GValue.xs

i will look into that as well.  for now, it's
spend-time-with-the-lovely-wife time.  :-)