Re: [REGRESSION] [PATCH] ->iter_parent returns invalid treeiterators

Thierry Vignaud said:
Thierry Vignaud <tvignaud mandrakesoft com> writes:

the last thing that prevent me from running rpmdrake was that
->iter_parent returned an invalid iterator, because it returned a
pointer on a stack object, which of course may have been overwriten
since (gtk+ developers should really think about adding magic numbers
to their structs for debugging purpose)

here's the fix:

btw, someone should audit all xs functions that allocate items on the
stack in order to catch those that directly return stack references

a lot of them should be caught as the complete tests are being written (the
whole point for them in the first place,) that being said there's soo much
stuff that it won't all be tested any time soon.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]