Re: [PATCH] add bidi support



Thierry Vignaud said:
"Ross McFarland" <rwmcfa1 neces com> writes:

the last two needed to take (and ignore) class names.

so i'll to reverse my s/(Gtk2::Widget)->(\w*direction)/\1::\2/ since
xs tree follow inline tree regarding this issue :-(

any function which needs to be called with a fully-qualified Package::name()
syntax instead of the Package->name() syntax is an implementation bug in the
bindings.

rationale: the former syntax does not allow client code to use @ISA to
override and extend class methods, whereas the latter does.

e.g.:

  package FreakyStuff;

  our @ISA = qw/ Gtk2::Widget /;

  sub set_text_direction {
          # do other stuff, like log the change or
          # make changes in child libraries
          shift->SUPER::set_text_direction (@_);
  }

  package main;

  FreakyStuff->set_text_direction (...);


-- 
muppet <scott at asofyet dot org>



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]