gtk_tree_path_new_from_indices and gtk_tree_row_reference_new



Aloha,

attached are two patches.

The first one implements gtk_tree_path_new_from_indices. The comment
that's currently there states that we should do the same that C does and
stop whenever we find a -1. I can't quite comprehend why this would be
necessary, since a) it's quite un-perl-ish and b) with XS' "items" we
have all we need to process the variable argument list. I also don't
understand the FIXME comment since all this function returns is a single
GtkTreePath.

The second one adds a change to gtk_tree_row_reference_new to the first
patch. It adds a class parameter to it and thus breaks the API. You'd
now do

  Gtk2::TreeRowReference -> new($model, $path);

instead of

  Gtk2::TreeRowReference::new($model, $path);

I don't know whether it's too late for API changes but considering that
the row reference stuff is rarely used I think that, in this case,
consistency weighs more than backwards compatability.

Since both changes apply to GtkTreeModel.xs and I don't know whether The
Administration will accept the API change I chose this copious two patch
thingy.

I tested both changes quite thoroughly as part of the upcoming
comprehensive test suite for all tree stuff I currently work on.

Bye,
-Torsten



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]