Re: gtk2-perl / GLib-GObject-CRITICAL from GSignal.c

[Guillaume Cottenceau <gc mandrakesoft com>]

goran kirra net writes:

> > -           }
> > +           } else
>
> Yes,
> thanks for spotting that one, logic thinko/typo.

np.

just following your idea: test if my tests still run, after a few
days of inaction from me, in which the team cowardly took
occasion to commit many things in my back :)).
 
> > While looking at that code, what would you think of replacing:
> >             if (strstr(pc->name, "selection_received")) {
> > by:
> >             if (!strcmp(pc->name, "selection_received")) {
>
> The diffence if subtile and 
> I am not finished with the selection stuff yet.

ok. was just wondering. since it seemed unprobable that it was on
purpose that you tested for substring of a so long thing such as
selection_received :).

> I might need some more cases in the logic here.

ok

-- 
Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/