Re: [gtk-osx-users] Setting module_extra_env['pkg-config'] discussion.





On Jan 15, 2022, at 7:46 AM, Pascal <p p14 orange fr> wrote:

Hello,

JHbuildrc line 622 is:
module_extra_env['pkg-config'] = {'PYTHON':sys.executable}
(https://gitlab.gnome.org/GNOME/gtk-osx/-/blob/master/jhbuildrc-gtk-osx#L622)

This overrides the previous line 364:
module_extra_env["pkg-config"] = {'CFLAGS': os.environ['CFLAGS'] + ' -std=gnu89'}
(https://gitlab.gnome.org/GNOME/gtk-osx/-/blob/master/jhbuildrc-gtk-osx#L364)

Shouldn't line 622 updates the value instead of overriding?

Probably, but since pkg-config seems to build fine with the CFLAGS being overridden I suspect that line 364 
can be removed.

Regards,
John Ralls



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]