Re: [gtk-osx-users] Pango error implicit declaration of function is invalid in C99.

[Pascal <p p14 orange fr>]

> Le 22 août 2020 à 12:11, Pascal <p p14 orange fr> a écrit :
>
>
> > Le 22 août 2020 à 10:39, Pascal <p p14 orange fr> a écrit :
> >
> > Hello,
> > I've a compiling error with Pango:
> >
> > % jhbuild build meta-gtk-osx-gtk3
> > ...
> >
> > *** Error during phase build of pango: ########## Error running ninja   *** [19/29]
> >
> > [1] Rerun phase build
> > [2] Ignore error and continue to install
> > [3] Give up on module
> > [4] Start shell
> > [5] Reload configuration
> > [6] Go to phase "wipe directory and start over"
> > [7] Go to phase "configure"
> > [8] Go to phase "clean"
> > choice: 
>
> Digging in the error, the define CAIRO_HAS_FC_FONT is not set.
> It seems that fontconfig should have been built before cairo.

Fontconfig is in the "after" section of Cairo, so it should be ok:

  <autotools id="cairo"
             autogenargs="--enable-pdf --enable-quartz --disable-xlib --without-x">
    <branch repo="freedesktop" module="cairo" revision="1.16"/>
    <dependencies>
      <dep package="pixman"/>
      <dep package="meta-gtk-osx-bootstrap"/>
      <dep package="freetype-no-harfbuzz"/>
    </dependencies>
    <after>
      <dep package="fontconfig"/>
    </after>
  </autotools>

Is it thus correct with the following fix?

diff --git a/modulesets/gtk-osx.modules b/modulesets/gtk-osx.modules
index 297b4fe..ed49555 100644
--- a/modulesets/gtk-osx.modules
+++ b/modulesets/gtk-osx.modules
@@ -107,10 +107,8 @@
       <dep package="pixman"/>
       <dep package="meta-gtk-osx-bootstrap"/>
       <dep package="freetype-no-harfbuzz"/>
-    </dependencies>
-    <after>
       <dep package="fontconfig"/>
-    </after>
+    </dependencies>
   </autotools>

Should I then push it to github?

Thanks, Pascal.
https://blady.pagesperso-orange.fr