Re: [gtk-osx-users] Building Glade on MaxOS 10.9.

[John Ralls <jralls ceridwen us>]

On Jul 6, 2015, at 9:35 PM, Philip Chimento <philip chimento gmail com> wrote:

On Mon, Jul 6, 2015 at 3:14 PM, John Ralls <jralls ceridwen us> wrote:

> On Jul 6, 2015, at 1:32 PM, Pascal <p p14 orange fr> wrote:
>
> Hello John, you're right.
>
> I got many errors, extract:
>
> glade-window.c:3277:25: error: implicit declaration of function 'GET_OBJECT' is
>      invalid in C99 [-Werror,-Wimplicit-function-declaration]
>          GtkWidget *menubar = GET_OBJECT (builder, GTK_WIDGET, "menubar");
>                               ^
> glade-window.c:3277:37: error: use of undeclared identifier 'builder'
>          GtkWidget *menubar = GET_OBJECT (builder, GTK_WIDGET, "menubar");
>                                           ^
> glade-window.c:3278:4: error: use of undeclared identifier 'GtkOSXApplication'
>          GtkOSXApplication *theApp = g_object_new(GTK_TYPE_OSX_APPLICAT...
>          ^
> glade-window.c:3278:23: error: use of undeclared identifier 'theApp'
>          GtkOSXApplication *theApp = g_object_new(GTK_TYPE_OSX_APPLICAT...
>                             ^
> glade-window.c:3278:45: error: use of undeclared identifier
>      'GTK_TYPE_OSX_APPLICATION'
>          GtkOSXApplication *theApp = g_object_new(GTK_TYPE_OSX_APPLICAT...
>                                                   ^
> glade-window.c:3282:4: error: implicit declaration of function
>      'gtk_osxapplication_set_menu_bar' is invalid in C99
>      [-Werror,-Wimplicit-function-declaration]
>          gtk_osxapplication_set_menu_bar(theApp, GTK_MENU_SHELL(menubar));
>          ^
>
> Was it better with previous glade version?

No, if you look at the 3.16 patch you’ll see that there were a lot of pretty basic fixes needed to get it to compile. I dunno offhand where GET_OBJECT is defined, but GtkOSXApplication changed to GtkosxApplication years ago because g-ir-scanner needed it. The 3.16 patch just ripped it out instead of fixing it.

If you put together a new patch I’ll replace the old one.

I believe I fixed this in git a while ago. The following two commits should do it:

https://git.gnome.org/browse/glade/commit/?id=e36e1ae6882d6e5345bcbf6f029f8239c4afd76f 

https://git.gnome.org/browse/glade/commit/?id=fc24963f93ea227ae6c627402166fa8184d6a51c

The glade-3-18 branch has these as well, so if there is another 3.18 point release then you should be able to drop the patch.

Unfortunately Glade hasn’t had a stable release in over a year, though there was an unstable 3.19.0 last  month so perhaps they’re targeting 3.20 for the next Gnome release this fall.

In the meantime I can roll those two commits into a patch pretty easily, thanks.

Regards,

John Ralls