Re: [gtk-osx-devel] [PATCH 3/3] Moduleset-stable: fixing the repository link of cups module

[John Ralls <jralls ceridwen us>]

> On Apr 29, 2015, at 8:15 AM, Kirill Moizik <kirill daynix com> wrote:
>
> The link in outdated. Updating to new link.
>
> Signed-off-by: Kirill Moizik <kirill daynix com>
> ---
> modulesets-stable/gtk-osx-bootstrap.modules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modulesets-stable/gtk-osx-bootstrap.modules b/modulesets-stable/gtk-osx-bootstrap.modules
> index 31127e7..f063d15 100644
> --- a/modulesets-stable/gtk-osx-bootstrap.modules
> +++ b/modulesets-stable/gtk-osx-bootstrap.modules
> @@ -23,7 +23,7 @@
>   <repository type="tarball" name="harfbuzz"
>               href="http://www.freedesktop.org/software/harfbuzz/release/"/>
>   <repository type="tarball" name="cups"
> -           href="http://ftp.easysw.com/pub/"/>
> +           href="https://www.cups.org/software/"/>
>   <repository type="tarball" name="itstool" href="http://files.itstool.org/"/>
>   <repository type="tarball" name="icu"
>               href="http://download.icu-project.org/files/"/>
> @@ -80,7 +80,7 @@
>   <!-- Cups is needed *only* for Tiger, and skipped otherwise -->
>   <autotools id='cups' autogen-sh='configure' skip-autogen='never'
>            autogenargs='DSOFLAGS="$LDFLAGS"'>
> -    <branch module="cups/1.2.12/cups-1.2.12-source.tar.bz2"
> +    <branch module="1.2.12/cups-1.2.12-source.tar.gz"
>           version="1.2.12" repo="cups"  checkoutdir='cups-1.2.12'/>
>     <dependencies>
>       <dep package="libtiff"/>

Don't send patches to mailing lists, they get lost and it's difficult to do code reviews or to keep track of 
status. Gnome policy is that they should be attached to Bugzilla bug reports (bugzilla.gnome.org, category 
Other, project gtk-mac-integration), but I also accept Github pull requests.

When preparing a patch to bugzilla, make a commit in your local repo with all of the changes and a good 
explanatory commit message (ideally the first line should be the bug report number and subject), then use 
`git format-patch` to turn the commit into a patch.

Pull requests work best if you create a feature branch in your github repo and submit the PR from there.

Regards,
John Ralls