Re: [gtk-osx-devel] [PATCH] gtk-mac-integration reference counting
- From: Richard Procter <richard n procter gmail com>
- To: gtk-osx-devel-list gnome org
- Subject: Re: [gtk-osx-devel] [PATCH] gtk-mac-integration reference counting
- Date: Tue, 7 Feb 2012 19:50:30 +1300
On 7/02/2012, at 5:09 PM, John Ralls wrote:
> On Feb 6, 2012, at 4:45 PM, Richard Procter wrote:
>> I believe clang is flagging unconventional naming here, at least, indirectly: it does not flag a potential leak if the returning function contains 'create' in its name (following the Core Foundation create rule [1], which I assume applies to the CGImage).
>
> Seems unlikely, especially since you're not using Apple's Clang. I'm back from travel, so I'll start testing it soon. GtkOsxApplication needs more unit tests anyway. ;-)
Ok, great :) I was surprised myself to see it pick that up but I've rerun it changing only the function name and that is sufficient to supresses the warning. I get the impression that Apple bundle the static analyser a few releases behind the cutting edge, which they (or someone) contribute to --- see the release notes if you're interested [1].
best
Richard.
[1] http://clang-analyzer.llvm.org/release_notes.html
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]