Re: [gtk-list] Gtk 1.2.7 Problem Found (was More info on theObjectManager/Gtk segfault)

[Tim Janik <timj gtk org>]

On Sat, 18 Mar 2000, Matthew wrote:

> 
> I found the problem that's causing ObjectManager to segfault when compiled
> against gtk 1.2.7.  The problem is located in gtk+-1.2.7/gtk/gtkctree.c,
> function gtk_ctree_node_set_row_data_full, starting at line 5186.
> 
> Here is the function as it appears in 1.2.7:
> 
> void
> gtk_ctree_node_set_row_data_full (GtkCTree         *ctree,
>                                                  GtkCTreeNode     *node,
>                                                  gpointer          data,
>                                                  GtkDestroyNotify  destroy)
> {
>   GtkDestroyNotify dnotify;
>   gpointer ddata;
> 
>   g_return_if_fail (ctree != NULL);
>   g_return_if_fail (GTK_IS_CTREE (ctree));
>   g_return_if_fail (node != NULL);
> 
>   dnotify = GTK_CTREE_ROW (node)->row.destroy;
>   ddata = GTK_CTREE_ROW (node)->row.data;
> 
>   GTK_CTREE_ROW (node)->row.data = data;
>   GTK_CTREE_ROW (node)->row.destroy = destroy;
> 
>   if (dnotify)
>     dnotify (ddata);
> 
> }

this is an important bug fix in 1.2.7, the old version would
leak the data set on a node, when reset. could you give more
information on why you think the 1.2.7 behaviour is broken?

> 
> Matthew
> 

---
ciaoTJ