Re: [gtk-list] GtkMenu keyboard navigation patch

[Tim Janik <timj gtk org>]

On Fri, 24 Sep 1999, Alexander Piskunov wrote:

> GTK 1.2.4 TODO list entry:
> > * The menu code should skip separators during keyboard navigation,
> >   whether they are sensitive or insensitive.
> 
> That was easy! Enjoy navigating Gnome panel main menu using keyboard.
> All separators are skipped now.
> 
> P.S Just read release announcement for GTK 1.2.5. I don't know if patch
> will work for it.
> --------------
> Patch:
> --------------
> <--Cut here!-->
> *** gtkmenushell.c.orig	Tue May 11 05:31:08 1999
> --- gtkmenushell.c	Fri Sep 24 10:32:38 1999
> ***************
> *** 866,870 ****
>   		 (!node ||
>   		  !GTK_WIDGET_IS_SENSITIVE (node->data) ||
> ! 		  !GTK_WIDGET_VISIBLE (node->data) ))
>   	    {
>   	      if (!node)
> --- 866,871 ----
>   		 (!node ||
>   		  !GTK_WIDGET_IS_SENSITIVE (node->data) ||
> ! 		  !GTK_WIDGET_VISIBLE (node->data) ||
> ! 		  !(GTK_BIN(node->data)->child) ))
>   	    {
>   	      if (!node)
> ***************
> *** 880,884 ****
>   		 (!node ||
>   		  !GTK_WIDGET_IS_SENSITIVE (node->data) ||
> ! 		  !GTK_WIDGET_VISIBLE (node->data) ))
>   	    {
>   	      if (!node)
> --- 881,886 ----
>   		 (!node ||
>   		  !GTK_WIDGET_IS_SENSITIVE (node->data) ||
> ! 		  !GTK_WIDGET_VISIBLE (node->data) ||
> ! 		  !(GTK_BIN(node->data)->child) ))
>   	    {
>   	      if (!node)
> 
> <---Cut here!--->

thanks for your efford, but this would also disable movement to the tearoff
items.
owen, did you intend a change like this to gtk_menu_shell_move_selected()
with additional checks for tear-off items, or did you have something else
in mind?

> 
> ------------------------------------------
> Tavs bezmaksas pasts - http://www.inbox.lv
> 

---
ciaoTJ