Gtk-Perl: Gtk::Toolbar::append_item



Greetings, programs!

I'm using Gtk-Perl cvs 19990930 and noticed the following "problem" with
the Gtk::Toolbar::append_item:

#line 32 "GtkToolbar.xs"
	RETVAL = gtk_toolbar_append_item(toolbar, text, tooltip_text,
tooltip_private_text, icon, NULL, NULL);

Note that NULL is passed in for the callback and user_data params.  Should
these not pass in NULL only if those params are not specified, and
otherwise pass them in?  The urgency of this modification is very low since
the RETVAL of gtk_toolbar_append_item is the widget that was appended, so
one can simply signal_connect the RETVAL.  This change would need to be
made to append_item, prepend_item, insert_item, append_element,
prepend_element, and insert_element

Thanks for all the work on the perl bindings; I've really been having a
blast playing with them.
James



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]