Re: Patch?

[Owen Taylor <otaylor gtk org>]

Daniel.Egger@t-online.de (Daniel Egger) writes:

> Hiho!
>
>  Please tell me is wrong with my patch which should be in the patch directory
>  for about 5 days.... I'd like to get some feedback....

If it is in the patch directory, it generally means that no decision
has been made one way or the other, probably because nobody has had
sufficient time to look at it.

I just took a look at your patch. All it seems to do to me is
completely omit drawing the upper-right and lower-left corners of the
shadow. That is, what is currently drawn as:

Key: (## = dark pixel, [] = mid pixel "  " = light pixel, 
      ^^ = background pixel. ?? = indeterminate pixel)
     

+-------------------------------+
|#############################  |
|##                         ##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|#############################  |
|	                        |
+-------------------------------+

becomes:

+-------------------------------+
|#############################??|
|##                         ##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|#############################  |
|??                             |
+-------------------------------+

Now, there would be some justification for:

+-------------------------------+
|#############################[]|
|##                         []  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##  ^^^^^^^^^^^^^^^^^^^^^^^##  |
|##[]#########################  |
|[]                             |
+-------------------------------+

Since, for mitred corners, those pixels are exactly half-filled
geometrically, but all the pixels need to get drawn, one way or the
other. Though the way it is drawn currently looks fine to me. (And
should be as good as any two-color way of drawing a etched border)

Perhaps though I've made a mistake in reading your patch?

Regards,
                                        Owen