A few minor signal corrections




GtkContainer
============

I think the container focus signal in gtkcontainer.c is slightly wrong.
Shouldn't the return value be GTK_TYPE_BOOL?

  container_signals[FOCUS] =
    gtk_signal_new ("focus",
                    GTK_RUN_LAST,
                    object_class->type,
                    GTK_SIGNAL_OFFSET (GtkContainerClass, focus),
                    gtk_container_marshal_signal_3,
 *** this one ->>   GTK_TYPE_DIRECTION_TYPE, 1,
                    GTK_TYPE_DIRECTION_TYPE);

The handler returns a gint (a gboolean really):

static gint gtk_container_real_focus        (GtkContainer      *container,
					     GtkDirectionType   direction);


GtkData
=======

Should this be at the end of gtk_data_class_init:

  class->disconnect = NULL;


GtkCList
========

Shouldn't the last arg to these functions be GTK_TYPE_GDK_EVENT?
(Actually they are in GTK 1.1)

  clist_signals[SELECT_ROW] =
    gtk_signal_new ("select_row",
		    GTK_RUN_FIRST,
		    object_class->type,
		    GTK_SIGNAL_OFFSET (GtkCListClass, select_row),
		    gtk_clist_marshal_signal_1,
	    GTK_TYPE_NONE, 3, GTK_TYPE_INT, GTK_TYPE_INT, GTK_TYPE_POINTER);
  clist_signals[UNSELECT_ROW] =
    gtk_signal_new ("unselect_row",
		    GTK_RUN_FIRST,
		    object_class->type,
		    GTK_SIGNAL_OFFSET (GtkCListClass, unselect_row),
		    gtk_clist_marshal_signal_1,
	    GTK_TYPE_NONE, 3, GTK_TYPE_INT, GTK_TYPE_INT, GTK_TYPE_POINTER);


Damon





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]