Re: Very small bug in gdk_gc_copy()




Daniel Stephens <daniel@cheeseplant.org> writes:

> > > The 0xffff is not sufficient to make sure that all components of the
> > > GC actually get copied.  Replacing it with 0xffffffff clears up the
> > > problem under Linux on the Intel.  I don't actually know anything
> > > about X, though, so I don't know if this is portable...
> > 
> > I think it should be OK. There is a _small_ chance that a server could
> > be implemented in such a way that that would give a BadValue error
> > (there are only 22 defined flags), but I think that is fairly
> > unlikely. I've made the change.
> 
> Of course you could do it properly with the (odd looking) expression...
> 
> 			~((~1) << GCLastBit);

Nice. I saw GCLastBit - but it didn't strike me that you could
use it like that...

                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]