Re: [PATCH] SEGV in gdkim.c (GTK+1.1.9)

[Owen Taylor <otaylor redhat com>]

Ullrich Hafner <hafner@informatik.uni-wuerzburg.de> writes:

> >>>>> "Shawn" == Shawn T Amundson <amundson@gimp.org> writes:
> 
>     Shawn> [...]
> 
>     Shawn> What is new in GTK+ 1.1.9:
> 
>     Shawn> * Check for broken glibc 2.0 mb functions and avoid them
> There's a bug in the file gdk/gdkim.c: character pointer
> 'current_locale' is used in strcmp without NULL pointer check.
> Here's a fix:
> 
> --- gdkim.c.orig        Thu Dec 17 13:46:15 1998
> +++ gdkim.c     Thu Dec 17 13:49:12 1998
> @@ -103,7 +103,7 @@
>  
>    current_locale = setlocale (LC_ALL, "");
>  
> -  if ((strcmp (current_locale, "C")) && (strcmp (current_locale, "POSIX")))
> +  if (current_locale && (strcmp (current_locale, "C")) && (strcmp (current_locale, "POSIX")))
>      {
>        gdk_use_mb = TRUE;

Thanks. Actually, it was meant to be:

    current_locale = setlocale (LC_ALL, NULL);

Which should never return NULL.

Regards,
                                        Owen