Re: REQUESTING REVIEW: Correct cursor handling for Sinhala

[Harshula <harshula gmail com>]

Hi,

I've opened a bug:
http://bugzilla.gnome.org/show_bug.cgi?id=451682

If you are planning on making any changes that effect Sinhala layout,
could you please request the Sinhala experts at
https://lists.sourceforge.net/lists/listinfo/sinhala-technical to review
your patch before you introduce regressions to Pango. Furthermore, just
because someone is South-Asian does not imply they have a clue about
Sinhala orthography.

Thanks,
#

On Mon, 2007-06-25 at 01:10 +1000, Harshula wrote:
> Hi,
> 
> I've only recently looked at Pango's cursor handling code, hence could
> those who are more familiar with this area please review this patch?
> 
> I will open a bug once the reviewers are happy.
> 
> Patch:
> http://cvs.savannah.nongnu.org/viewvc/*checkout*/sinhala/patches/pango-1.16.4-cursor-position-sinhala1.patch?root=sinhala
> 
> Testcase:
> http://cvs.savannah.nongnu.org/viewvc/*checkout*/sinhala/patches/cursor-position-testcase.txt?root=sinhala
> 
> Changelog:
> ---------------------------------------------------------
> * BUGFIX: Correct the broken Repaya handling code.
> * BUGFIX: Consonant clusters do NOT result in implicit conjuncts in
> SINHALA orthography.
> * The cursor should treat as a single glyph:
>     SINHALA CONS + 0x0DCA + 0x200D + SINHALA CONS
>     SINHALA CONS + 0x200D + 0x0DCA + SINHALA CONS
> ---------------------------------------------------------
> 
> cya,
> #