Re: gdef memory leaks



> > I hope my patch fixes two memory leaks if gdef.
> > 
> > 1. gdef allocated in TT_New_GDEF_Table
> > 
> >   if ( ALLOC( gdef, sizeof( *gdef ) ) )
> >       return error;
> > 
> > 2. memory allocated in TT_GDEF_Build_ClassDefinition
> >    It seems that the memory allocated in TT_GDEF_Build_ClassDefinition
> >    are expected to be freed in Free_ClassDefinition in ftxopen.c.
> >    However, the memory will not be freed because cd->loaded is
> >    always false.
> > 
> >       void  Free_ClassDefinition( TTO_ClassDefinition*  cd,
> > 				  FT_Memory             memory )
> >       {
> > 	if ( !cd->loaded )
> > 	  return;
> > 
> >    I suppose cd->loaded should be set TRUE in TT_GDEF_Build_ClassDefinition.
> 
> Can I ask you to put this patch into bugzilla.gnome.org? It will
> be easier for me to handle it that way.

I've just put.

> > These leaks are found by memprof.
> > efence also reports another problem.
> 
> What?

Sorry, I cannot reproduce the problem.
I'll report it when I can reproduce.

Masatake YAMATO



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]