Re: Pango 1.2.5 Bugs

[Owen Taylor <otaylor redhat com>]

On Mon, 2003-09-08 at 10:47, Edward H. Trager wrote:
> Hi,
> 
> (1) PANGO 1.2.5 THAI RENDERING BUG
> 
> In this mailing list on September 3rd Khun Theppitak noted a serious bug in Pango 1.2.5's Thai
> XFT module which I (and certainly others) have also noticed.  Can Khun Theppitak or someone
> please tell me where I can get the accepted fix for this bug?  Has a patch been submitted in
> CVS yet?

http://bugzilla.gnome.org/show_bug.cgi?id=121488

I'd sort of like to go with the simplest possible fix, which is
attached.

But I need to sort out with Theppitak, who wants something more
complicated.

> (2) PANGO 1.2.5  4X SCALING BUG
> 
> I am working on bug fixes in some software written by a friend of mine which obtains glyph 
> outlines from TrueType fonts via Pango and Freetype2.  When I used libpangoft2 v.1.2.3, 
> everything worked fine.  But with libpangoft2 v. 1.2.5, glyph outlines are erroneously scaled 
> four times larger than before!
> 
> Has anyone else noticed this bug? Can someone clue me in to what I need to do to fix it?  Either
> this is a real bug in Pango 1.2.5, or else it is a bug in our software not doing proper 
> initialization.  Since I am completely new to developing with Pango, I'm not sure which it is.
> Has anyone else noticed a similar phenomenon?  Any leads would be most welcome!

Not having seen your code, I have no idea. A small standalone test case
in bugzilla would be most appreciated.

Regards,
							Owen


--- pango-1.2.5/modules/thai/thai-shaper.h.thai	2003-09-08 12:04:55.000000000 -0400
+++ pango-1.2.5/modules/thai/thai-shaper.h	2003-09-08 12:05:01.000000000 -0400
@@ -1,6 +1,8 @@
 #ifndef __THAI_SHAPER_H__
 #define __THAI_SHAPER_H__
 
+#include "config.h"
+
 #ifdef HAVE_X
 #include "pangox.h"
 #endif